-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preliminary tadoX support #90
Conversation
@abn Here's what I have so far for TadoX support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment/question.
Also ugg. I really wish tado can get their act together when it comes to apis. It just feels like every feature is developed in isolation by a brand new team without any access to existing features. 😮💨
Right! I thought they'd started getting their act together just before the EnergyIQ stuff was added, then that was a total mess, now this. There's absolutely no consistency. |
I've pushed more updates to the typing based on @jm-duke feedback and I've tweaked the code for { "temperature": { "celsius": 18 } } to { "temperature": { "value": 18 } } clearly not catering for the North American market anymore 😅 |
b901fe2
to
a2398ea
Compare
commit: |
tadox: add missing hops endpoints
This PR adds preliminary support for TadoX based on this Python library
It doesn't attempt to guard against using older v2 APIs - I'm not sure whether they'll respond.
Also, the typing could be totally wrong on the responses, I've assumed that they're the same as the v2 responses.