Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preliminary tadoX support #90

Merged
merged 24 commits into from
Dec 4, 2024
Merged

feat: add preliminary tadoX support #90

merged 24 commits into from
Dec 4, 2024

Conversation

mattdavis90
Copy link
Owner

@mattdavis90 mattdavis90 commented Nov 9, 2024

This PR adds preliminary support for TadoX based on this Python library

It doesn't attempt to guard against using older v2 APIs - I'm not sure whether they'll respond.

Also, the typing could be totally wrong on the responses, I've assumed that they're the same as the v2 responses.

@mattdavis90
Copy link
Owner Author

@abn Here's what I have so far for TadoX support

Copy link
Contributor

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment/question.

Also ugg. I really wish tado can get their act together when it comes to apis. It just feels like every feature is developed in isolation by a brand new team without any access to existing features. 😮‍💨

@mattdavis90
Copy link
Owner Author

One comment/question.

Also ugg. I really wish tado can get their act together when it comes to apis. It just feels like every feature is developed in isolation by a brand new team without any access to existing features. 😮‍💨

Right! I thought they'd started getting their act together just before the EnergyIQ stuff was added, then that was a total mess, now this. There's absolutely no consistency.

@mattdavis90
Copy link
Owner Author

mattdavis90 commented Nov 16, 2024

I've pushed more updates to the typing based on @jm-duke feedback and I've tweaked the code for manualControl to hopefully work with TadoX - I hadn't fully appreciated the change from

{ "temperature": { "celsius": 18 } }

to

{ "temperature": { "value": 18 } }

clearly not catering for the North American market anymore 😅

@mattdavis90 mattdavis90 force-pushed the tado-x branch 3 times, most recently from b901fe2 to a2398ea Compare November 23, 2024 16:40
Copy link

pkg-pr-new bot commented Nov 23, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mattdavis90/node-tado-client@90

commit: 1c30675

@mattdavis90 mattdavis90 merged commit 97f5886 into master Dec 4, 2024
9 checks passed
@mattdavis90 mattdavis90 deleted the tado-x branch December 4, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants