Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a publish workflow #62

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

abn
Copy link
Contributor

@abn abn commented Oct 25, 2024

If this does not match the release wofklow today, please feel free to close. The workflow expects the following release flow.

  1. A new version is tagged using pnpm version command.
  2. The new tag (v<version>) and default branch is pushed to remote.
  3. The workflow creates a new release on GitHub associated with the tag.
  4. The workflow builds the package for publishing.
  5. The workflow publishes package to npmjs.

The workflow requires the NPM_TOKEN action secret to be set to a valid token.

@abn abn mentioned this pull request Oct 26, 2024
@mattdavis90
Copy link
Owner

NPM_TOKEN already exists for the action and there's a pnpm build just before publish so I'm pretty happy this is good to go. I'll merge it now, cut a new release and see how we get on. Thank

@mattdavis90 mattdavis90 merged commit 096be89 into mattdavis90:master Oct 26, 2024
2 checks passed
@mattdavis90
Copy link
Owner

One tweak required but the workflow is working and v0.17.0 is released with your changes in it!

Thank you so much for all the PRs, the tidying up, the workflows, etc. This is awesome!! 🚀

@abn abn deleted the ci/publish branch October 26, 2024 10:18
@abn
Copy link
Contributor Author

abn commented Oct 26, 2024

It is odd pnpm publish does not understand the tag. /shrug

Thanks for merging and fixing, and thank you for the library - it has been very useful for me. Happy to help where I can. 😄

@mattdavis90
Copy link
Owner

Yes, very strange

No problem, I'm glad it is helpful to people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants