Add SageMaker Image IAM permissions and terminator - #342
Open
JanLikar wants to merge 2 commits into
Open
Conversation
Add sagemaker:CreateImage, sagemaker:DescribeImage, sagemaker:UpdateImage, sagemaker:DeleteImage, sagemaker:ListImages, sagemaker:AddTags, sagemaker:DeleteTags, sagemaker:ListTags permissions needed for the amazon.ai sagemaker_image integration tests. Also add AmazonSageMakerFullAccess to the allowed policies for iam:AttachRolePolicy so the test IAM role can be created correctly.
JanLikar
force-pushed
the
add-sagemaker-image-permissions
branch
from
August 19, 2026 08:08
33ee83d to
32f7d06
Compare
chynasan
approved these changes
Aug 19, 2026
4 tasks
Collaborator
|
@JanLikar Thank you for working on this. We do not want to create additional policy files, though, I opened this PR that will create some room for these policies that I'd like to merge it first and then rebase your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the IAM permissions and terminator needed for the
sagemaker_imageintegration tests in ansible-collections/amazon.ai (see PR #54).Changes
aws/policy/paas.yamlsagemaker:CreateImage,sagemaker:DescribeImage,sagemaker:UpdateImage,sagemaker:DeleteImagetoAllowResourceRestrictedActionsWhichIncurNoFeeswith resourcearn:aws:sagemaker:...:image/*sagemaker:ListImages,sagemaker:AddTags,sagemaker:DeleteTags,sagemaker:ListTagstoAllowUnrestrictedResourceActionsWhichIncurNoFeesaws/policy/security-services.yamlarn:aws:iam::aws:policy/AmazonSageMakerFullAccessto the allowediam:PolicyArncondition foriam:AttachRolePolicyso the test IAM role can be set up correctlyaws/terminator/paas.pySageMakerImageterminator class to clean up leaked SageMaker Image resources after test runs, following the same pattern as the existingSageMakerCodeRepositoryterminator