Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@hevanaa
Copy link
Contributor

@hevanaa hevanaa commented Feb 26, 2017

This is now done against testing branch. I've also added the KB in question and the K70 LUX non-RGB to the IS_MONOCHROME macro. Hopefully this is correct.

@hevanaa
Copy link
Contributor Author

hevanaa commented Feb 26, 2017

Hmm, something went wrong there.

@hevanaa
Copy link
Contributor Author

hevanaa commented Feb 26, 2017

OK, think I solved the merge conflict (testing branch had changed after I forked it).

@tatokis
Copy link
Collaborator

tatokis commented Feb 26, 2017

From my understandint, the difference between a device being (!IS_RGB) or (IS_RGB && IS_MONOCHROME), is that the latter, while leveraging the RGB protocol, can allow for per-key lighting.
From Corsair's site I can see that both of these keyboard do support it, so we should be okay. Just need someone to test it.

Looks OK to me.

@hevanaa
Copy link
Contributor Author

hevanaa commented Feb 26, 2017

I've compiled and tested with my K70 LUX non-RGB. The Rainbow demo stopped working. The Trippy demo still worked. I guess the IS_MONOCHROME is no good then?

@hevanaa
Copy link
Contributor Author

hevanaa commented Feb 26, 2017

Couldn't get it to work at all with !IS_RGB. I'm removing them both from IS_MONOCHROME for now.

@hevanaa
Copy link
Contributor Author

hevanaa commented Feb 26, 2017

There must be some difference with the Strafe model (that has the IS_MONOCHROME macro) and at least this K70 LUX (non-RGB). Most things work in the GUI, except that pressing the Change Color button freezes the interface, but this happens both with if it is in IS_MONOCHROME and not (and it has always been like that with this model).

@tatokis
Copy link
Collaborator

tatokis commented Feb 26, 2017

pressing the Change Color button freezes the interface That's a Qt bug, we have info about it in the readme.

@ghost
Copy link

ghost commented Feb 26, 2017

Cross-reference to #86.

Works for @koanya who owns such keyboard. See #55 (comment).

@tatokis
Copy link
Collaborator

tatokis commented Feb 26, 2017

My guess is these keyboards discard the colour packets, so it should be safe to add them for now.

@tatokis tatokis merged commit 7e0ebab into mattanger:testing Feb 26, 2017
tatokis added a commit that referenced this pull request Feb 26, 2017
@hevanaa hevanaa deleted the testing branch March 1, 2017 17:48
frickler24 added a commit to frickler24/ckb-next that referenced this pull request Mar 1, 2017
See issue mattanger#87. If the KB is noted as a monochrome, the brightness
of the keyboard does not change if a color profile is loaded.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants