Skip to content

Align Grey Colours in Dark Mode in the Webstepper - #1

Closed
matt-dahlgren wants to merge 1 commit into
webstep-darkmode-syntaxfrom
aligning-dark-elements
Closed

Align Grey Colours in Dark Mode in the Webstepper#1
matt-dahlgren wants to merge 1 commit into
webstep-darkmode-syntaxfrom
aligning-dark-elements

Conversation

@matt-dahlgren

@matt-dahlgren matt-dahlgren commented Mar 6, 2026

Copy link
Copy Markdown
Owner

Proposed Changes

The colour that a11yDark renders the CodeDisplay to in dark mode is a separate colour than what was already being rendered as the paper colour. This change sets both colours to be equal.

...

Before:
Screenshot 2026-03-06 at 02 06 09

After:
Screenshot 2026-03-06 at 01 56 33

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant