adding window size check to analyze function#43
Draft
frankiecancino wants to merge 2 commits into
Draft
Conversation
Collaborator
frankiecancino
commented
Aug 26, 2020
- Adding same window size check to analyze function
- Added tests to assert the error returned from analyze
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 91.79% 91.80% +0.01%
==========================================
Files 29 29
Lines 2205 2208 +3
==========================================
+ Hits 2024 2027 +3
Misses 181 181
Continue to review full report at Codecov.
|
Contributor
|
@frankiecancino do you have some time to fix the merge conflicts? |
Collaborator
Author
|
Yeah, this PR is a little outdated. I'll pull in the new changes and try to fix this code coverage. I was working on this one night then just lost track |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.