fix: JSON arg parsing in CLI #236
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the
--inputand--dataparameters for the CLI are delcared as:This results in unexpected parsing behavior.
With this declaration
clap'svalue_parserdefaults to theFrom<String>implementation forserde_json::Valueto convert the provided argument. TheFrom<String>always results inserde_json::Value::String(...), it does not parse a string containing serialized JSON data, which is not intended I assume.This, to the best of my knowledge, does prevent users from specifying a JSON object, everything will be treated as a string.
I added a explicit
value_parserattribute such thatserde_value::from_stris used, which tries to parse a string (unfortunate naming maybe in this context).