This repository was archived by the owner on May 30, 2023. It is now read-only.
Display cause of invalid config error #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it, the 'go build' will result in the following error: > go build: cannot write multiple packages to non-directory bin/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This patch lets the user know the cause of configuration errors, instead of "no user configuration found". Most notably when the configuration file contains invalid JSON. Hopefully fixing #94 and #95.
PS: I only added a check for empty AccessToken and not the other values of the config file, as it seems the application still works without a userID or deviceID.
edit: PS2: I've also included a README fix in a separate commit, because it doesn't deserve its own pull request in my opinion.
Without it, the 'go build' will result in the following error:
With best regards,
Remi