sdk: Replace hyper with axum for local servers #3357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyper::Server was dropped in hyper 1, without a replacement. Signed-off-by: Kévin Commaille <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3357 +/- ##
==========================================
+ Coverage 83.64% 83.65% +0.01%
==========================================
Files 242 242
Lines 25016 25012 -4
==========================================
+ Hits 20924 20925 +1
+ Misses 4092 4087 -5 ☔ View full report in Codecov by Sentry. |
Version 0.7.5 triggers a warning in our version of rust nightly in CI, but we can't update it to a recent version because it triggers a warning caused by displaydoc Signed-off-by: Kévin Commaille <[email protected]>
Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyper::Serverwas dropped in hyper 1, without a replacement. If we want to have all crates depending on http 1 in the end, we need to replace it.The SSO login was tested to work with Fractal, and the oidc_cli example was tested too.
Related to #3255.