Skip to content

MSC4140: support filters on delayed event lookup #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

MSC4140: support filters on delayed event lookup #5038

wants to merge 6 commits into from
+48 −18

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Oct 10, 2025 •
edited
Loading

Support looking up scheduled/finalised delayed events, and looking up a single delayed event.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@AndrewFerr
MSC4140: support filters on delayed event lookup
d562dc0 
Support looking up scheduled/finalised delayed events, and looking up a
single delayed event.
@AndrewFerr
Add test coverage for delayed event lookup filters
5ec9dd9
@AndrewFerr
Prettier
a4a2f6b
@AndrewFerr AndrewFerr requested a review from a team as a code owner October 10, 2025 08:12
@AndrewFerr AndrewFerr requested review from a team and toger5 and removed request for a team October 10, 2025 08:15
Half-Shot
Half-Shot reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts

@AndrewFerr
Support single or multiple delayIds
81a63bd 
As it may be more common to look up a single delayed event than to look
up many of them, support passing a single delayID in the lookup function
instead of needing to pass a single-element array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Half-Shot Half-Shot Half-Shot left review comments

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

@toger5 toger5 Awaiting requested review from toger5 toger5 was automatically assigned from matrix-org/element-call-reviewers

Assignees

No one assigned

Labels

T-Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewFerr @Half-Shot @t3chguy