-
-
Notifications
You must be signed in to change notification settings - Fork 643
[MatrixRTC] Multi SFU support + m.rtc.member event type support #5022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename Focus -> Transport - add RtcMembershipData (next to `sessionMembershipData`) - make `new CallMembership` initializable with both - move oldest member calculation into CallMembership Signed-off-by: Timo K <[email protected]>
8f89fb7
to
29879e8
Compare
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
a6c0b27
to
f03fc94
Compare
Signed-off-by: Timo K <[email protected]>
f03fc94
to
25f4d6f
Compare
Signed-off-by: Timo K <[email protected]>
8341d9c
to
84a3d56
Compare
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
robintown
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks like a good first shippable iteration!
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Both Timo and I have given our takes on all outstanding comments and I agree that they've been properly addressed.
Co-authored-by: Robin <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
m.rtc.member
event type.m.rtc.member
.CallMembership
can now be constructed fromm.rtc.member
and exposes the same API shape asm.call.member
to the RTC session.CallMembership
(was previously in the membership manager). This removes unnecessary coupling: theRTCSession
passes the context required byCallMembership
directly.useRtcMemberFormat
to control sendingm.rtc.member
instead ofm.call.member
.useStickyEvent
in a follow-up when we consolidate the rollout.getFocusInUse
.MatrixRTCSession.getActiveFocus
→MatrixRTCSession.resolveActiveFocus
.CallMembership
API to compute the active transport (BREAKING).activeFocus: Focus
tomulti_sfu_focus: Transport
.multi_sfu_focus
implies multi-SFU mode;undefined
falls back to the oldest-membership selection.Breaking changes
getFocusInUse()
.getActiveFocus()
toresolveActiveFocus()
.join(sessionId, activeFocus: Focus)
join(sessionId, multi_sfu_focus?: Transport)
multi_sfu_focus
→ use multi-SFU with the provided transport.undefined
→ legacy behavior using the oldest membership.Todos for consumers updating the PR (currently only known: Element Call):
getActiveFocus()
withresolveActiveFocus()
.getFocusInUse()
.join(...)
to passmulti_sfu_focus
only when opting into multi-SFU.Backward compatibility and rollout
CallMembership
can handle bothm.call.member
andm.rtc.member
, so existing rooms continue to work.useRtcMemberFormat
:false
(default): continue to emitm.call.member
.true
: emitm.rtc.member
.join(sessionId, multi_sfu_focus?: Transport)
signature.Checklist