-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow making non-native site links server-absolute #26
Conversation
The top level won't resolve for the other websites that use the theme, though. Ie mpl-third-party etc? |
Locally maybe, but not once on the site. They are all on the same server. Maybe we need an option as in matplotlib/mpl-brochure-site#41? |
c780b73
to
251a6f8
Compare
OK, I modified the |
Alternatively, perhaps this should be |
docs/conf.py
Outdated
"native_site": False | ||
# Determines the type of links produced in the navigation header: | ||
# - absolute: Links point to the URL https://matplotlib.org/... | ||
# - relative: Links point to top-level of the server /... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Elliott on a a call, suggested this be rename to "server_stable" or something similar..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and rebased.
... instead of globally absolute with an explicit server name. This allows the docs to be served from a different server (e.g., on localhost), without links leaking out to the real matplotlib.org.
Due to the merging of matplotlib/mpl-sphinx-theme#26
Due to the merging of matplotlib/mpl-sphinx-theme#26
... instead of globally absolute with an explicit server name. This allows the docs to be served from a different server (e.g., on localhost), without links leaking out to the real matplotlib.org.