-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build system and rebuild with numpy >= 2.0 #611
base: develop
Are you sure you want to change the base?
Conversation
Perhaps one of the maintainers can comment on the build failure. Pinging @kant 🔔 |
@cvanelteren The error is coming because of the deprecated versions used in all the artifacts actions; I appreciate all your efforts in this PR, and I think it is actually a good moment to start thinking of
My only concern with the current PR is that it makes several big changes all at once, I would be in favour of addressing each of the current problems one by one in separate PR. I think that, as of today, the |
It is not currently possible to create extension modules in |
@molinav no worries if this PR is trashed ;-). I wasn't keeping track of the main. I am happy to chip in to work on stuff. I don't have full overview of the pipeline but noticed some verbose and missing stuff in I agree that this is perhaps a bit too rushed and fast. We could split this PR up by first tackling To answer one of you questions:
Yes I have included it as such in the PR here |
Hi there,
I made some changes to the build chain and update the numpy dependencies. The tests pass both here as in our package Ultraplot. Let me know if you wish me to comment on these changes.
Sincerely,
C