Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yaml from classes #119

Closed
wants to merge 82 commits into from
Closed

Remove yaml from classes #119

wants to merge 82 commits into from

Conversation

JulienRaynal
Copy link
Collaborator

@JulienRaynal JulienRaynal commented Feb 19, 2025 •
edited
Loading

Removed Yaml from yaml_data (kept some references for the yaml writer)
Do I need to also change the file name ?

✓ (python3.10) Running tests
✓ (python3.11) Running tests
✓ (python3.11) Running tests

Julien Raynal added 30 commits February 19, 2025 11:14
REPLACE: src/stimulus/typing/__init__ -> changed YamlGlobalConfig to …
d5fb8e8 
…GlobalConfig
REPLACE: src/stimulus/utils/yaml_data.py -> changed YamlGlobalConfig …
89b5c26 
…to GlobalConfig
REPLACE: tests/typing/test_typing.py -> changed YamlGlobalConfig to G…
c6a38e7 
…lobalConfig
REPLACE: src/stimulus/typing/__init__.py -> Changed YamlColumnsEncode…
5ba13f0 
…r to ColumnsEncoder
REPLACE: src/stimulus/utils/yaml_data.py -> Changed YamlColumnsEncode…
1863ced 
…r to ColumnsEncoder
REPLACE: tests/typing/test_typing.py -> Changed YamlColumnsEncoder to…
e9c40eb 
… ColumnsEncoder
REPLACE: tests/typing/test_typing.py -> Changed YamlColumns to Columns
f55b7f6
REPLACE: tests/data/loaders.py -> Changed YamlColumns to Columns
11062b4
REPLACE: tests/typing/__init__.py -> Changed YamlColumns to Columns
c370891
REPLACE: src/stimulus/utils/yaml_data.py -> Changed YamlColumns to Co…
61e5787 
…lumns
REPLACE: src/stimulus/utils/yaml_data.py -> Changed YamlTransformColu…
3c45094 
…mnsTransformation to TransformColumnsTransformation
REPLACE: src/stimulus/typing/__init__.py -> Changed YamlTransformColu…
ec66cdf 
…mnsTransformation to TransformColumnsTransformation
REPLACE: tests/data/test_data_handlers.py -> Changed YamlTransformCol…
4746659 
…umnsTransformation to TransformColumnsTransformation
REPLACE: tests/typing/test_typing.py -> Changed YamlTransformColumnsT…
1f99221 
…ransformation to TransformColumnsTransformation
REPLACE: src/stimulus/utils/yaml_data.py -> Changed YamlTransformColu…
3ffe710 
…mns to TransformColumns
REPLACE: src/stimulus/typing/__init__.py -> Changed YamlTransformColu…
5d0cfa2 
…mns to TransformColumns
REPLACE: tests/data/test_data_handlers.py -> Changed YamlTransformCol…
edede13 
…umns to TransformColumns
REPLACE: tests/typing/test_typing.py -> Changed YamlTransformColumns …
53fe62e 
…to TransformColumns
REPLACE: src/stimulus/utils/yaml_data.py -> Changed YamlTransform to …
fd8f92a 
…Transform
REPLACE: src/stimulus/data/loaders.py -> Changed YamlTransform to Tra…
93bfe2e 
…nsform
REPLACE: src/stimulus/typing/__init__.py -> Changed YamlTransform to …
0f7da0d 
…Transform
REPLACE: tests/data/test_data_handlers.py -> Changed YamlTransform to…
b9f1b3a 
… Transform
REPLACE: tests/typing/test_typing.py -> Changed YamlTransform to Tran…
ac3aa00 
…sform
REPLACE: tests/utils/test_data_yaml.py -> Changed YamlTransform to Tr…
b1cc3aa 
…ansform
REPLACE: src/stimulus/cli/check_model.py -> Changed YamlSplit* to Split*
1c7e996
REPLACE: src/stimulus/cli/split_csv.py -> Changed YamlSplit* to Split*
940bb59
REPLACE: src/stimulus/cli/split_split.py -> Changed YamlSplit* to Split*
9e4f368
REPLACE: src/stimulus/cli/split_transforms.py -> Changed YamlSplit* t…
a4a9e6b 
…o Split*
REPLACE: src/stimulus/cli/transform_csv.py -> Changed YamlSplit* to S…
d9baee1 
…plit*
REPLACE: src/stimulus/cli/tuning.py -> Changed YamlSplit* to Split*
7a99a54
Julien Raynal added 24 commits February 19, 2025 15:16
CHANGE: src/stimulus/yaml_data.py -> Changed left variables to remove…
e809194 
… yaml mentions
FORMATTING: src/stimulus/cli/check_model.py
3027d37
FORMATTING: src/stimulus/cli/split_csv.py
5418c00
FORMATTING: src/stimulus/cli/split_transforms.py
7dea223
FORMATTING: src/stimulus/cli/transform_csv.py
129bd04
FORMATTING: src/stimulus/cli/tuning.py
9f583c1
FORMATTING: src/stimulus/data/data_handlers.py
d52aae5
FORMATTING: src/stimulus/data/loaders.py
1d096fe
FORMATTING: src/stimulus/learner/raytune_learner.py
5c263a0
FORMATTING: src/stimulus/typing/__init__.py
f377f07
FORMATTING: src/stimulus/utils/yaml_data.py
c5dbac0
FORMATTING: tests/cli/test_check_model.py
34191e2
FORMATTING: tests/cli/test_shuffle_csv.py
7f973d4
FORMATTING: tests/cli/test_split_split.py
8aafd46
FORMATTING: tests/cli/test_split_transforms.py
f97bc24
FORMATTING: tests/cli/test_tuning.py
e9c9561
FORMATTING: tests/data/test_data_handlers.py
b80560a
FORMATTING: tests/data/test_experiment.py
40cb045
FORMATTING: tests/data/transform/test_data_transformers.py
d1991ef
FORMATTING: tests/learmes/test_raytune_learner.py
5306445
FORMATTING: tests/utils/test_data_yaml.py
d7d5656
FIX: references to old yaml functions
26f8b3a
FIX: multiple files -> fix merge conflict
abc4157
FORMATTING: formatting some files
216298d
@JulienRaynal JulienRaynal linked an issue Feb 19, 2025 that may be closed by this pull request
docs: rewrite YamlClasses to remove Yaml prefix #39
Open
mathysgrapotte
mathysgrapotte requested changes Feb 20, 2025
View reviewed changes
Copy link
Owner

@mathysgrapotte mathysgrapotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! only problem is that linting is failing, you can run make check, seems like the errors can be fixed by running make format!

@mathysgrapotte mathysgrapotte mentioned this pull request Feb 20, 2025
Merged
@mathysgrapotte
Copy link
Owner

stale, see #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathysgrapotte mathysgrapotte mathysgrapotte requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: rewrite YamlClasses to remove Yaml prefix
2 participants
@JulienRaynal @mathysgrapotte