Brent Minimizer #728
Open
Brent Minimizer #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was one of the people who worked on getting the existing minimizers/solvers into MathNet Numerics. I underestimated the effort left where I took it up and while we got some solvers merged there's a lot of things that could be improved and added. To me this looks like a great initiative (I'm not a maintainer though). |
blhough
reviewed
Jan 8, 2021
| var obj = ObjectiveFunction.ScalarValue(f1); | ||
| var r1 = algorithm.FindMinimum(obj, -2, 2); | ||
|
|
||
| Assert.That(Math.Abs(r1.MinimizingPoint - 3.0), Is.LessThan(1e-4)); |
There was a problem hiding this comment.
The upper bound is x≤2 so it should not reach the global min at x=3.
I believe the expected MinimizingPoint is x=2
The GoldenSectionMinimizer actually has a bug where it doesn't respect the bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I recently was looking for a Brent minimizer when porting some python code to C# and I was hoping to find it here.
FindMinimum.OfScalarFunctionConstrained()was pretty close, but given it is Golden Section under the covers, there were discrepancies with some inputs. I ended up porting the version from scipy _minimize_scalar_bounded().I'd love to give back and contribute this port (and perhaps expand on it a little bit). Is this something of interest to the project? I've started a PR with a simple mock up of the rough API and tests I was thinking about (copied from GoldenSectionMinimizer).
Also, I noticed that there was quite a history with optimizers (#489, #173), so I thought I'd check first. I see that a BrentMinimizer class was considered in the past optimization-1. But it doesn't look like this has been updated in quite some time. Any insight here would be great.