Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Oct 13, 2025

This PR prevents a potential circular dependency when a tex extension that loads a font extension is loaded while the output jax is being loaded. If the output jax is not yet loaded but requests the extension and the font-extension lists the output jax as a dependency, then both are waiting for the other to finish before they finish, and that means neither load will be marked as complete, and MathJax will wait forever.

The issue arose in this post on the developer's list, and the first message gives an example of when that occurs.

The dependency is needed in other cases (like in the lab) when the extension may be loaded before the output jax has been loaded, so that it will wait until the output jax is loaded.

@dpvc dpvc requested a review from zorkow October 13, 2025 19:50
@dpvc dpvc added this to the v4.0.1 milestone Oct 13, 2025
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.67%. Comparing base (59a9b65) to head (0c970bb).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1366   +/-   ##
========================================
  Coverage    86.67%   86.67%           
========================================
  Files          338      338           
  Lines        84268    84270    +2     
  Branches      4783     4784    +1     
========================================
+ Hits         73039    73041    +2     
  Misses       11206    11206           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit e9765e6 into develop Oct 14, 2025
3 checks passed
@dpvc dpvc deleted the fix/font-extension branch October 14, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants