Skip to content

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Oct 13, 2025

This PR addresses a problem with the braket TeX package where arguments to macros like \set are not properly handled if the braces don't match. E.g., \set{ throws an untapped error, while \set} produces an empty set with no error.

These situations are handled by calling parser.GetArgument(name), which does the checking for balanced braces or missing arguments, but then putting the parser.i back to what it was. That way, the error messages will be produced when needed, and others the parsing is handled as it currently is.

The missing argument error message is no longer needed, as that is handled by the GetArgument() call.

Resolves issue mathjax/MathJax#3447.

@dpvc dpvc requested a review from zorkow October 13, 2025 19:06
@dpvc dpvc added this to the v4.0.1 milestone Oct 13, 2025
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.67%. Comparing base (59a9b65) to head (c98ed35).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1365      +/-   ##
===========================================
- Coverage    86.67%   86.67%   -0.01%     
===========================================
  Files          338      338              
  Lines        84268    84263       -5     
  Branches      4783     3150    -1633     
===========================================
- Hits         73039    73034       -5     
- Misses       11206    11229      +23     
+ Partials        23        0      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants