Fix handling of argument to \set and others. (mathjax/MathJax#3447) #1365
+19
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a problem with the
braket
TeX package where arguments to macros like\set
are not properly handled if the braces don't match. E.g.,\set{
throws an untapped error, while\set}
produces an empty set with no error.These situations are handled by calling
parser.GetArgument(name)
, which does the checking for balanced braces or missing arguments, but then putting theparser.i
back to what it was. That way, the error messages will be produced when needed, and others the parsing is handled as it currently is.The missing argument error message is no longer needed, as that is handled by the
GetArgument()
call.Resolves issue mathjax/MathJax#3447.