Fix for 'isAllowed' test in VDPickerYears.spec.js #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dayjs(date, 'YYYY-MM-DD').get('year') was failing to convert
a number into a year.
For example, if date = 2020, it would return 2019. It's necessary
to pass a formated date to avoid this bad conversion.
georgelazar
approved these changes
Aug 16, 2022
|
So it looks like if you change your time zone to a negative one like US year 2021 is disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isBeforeDate(date, beforeDate, type) was failing to convert a simple number into a year, causing 2019 to be an invalid year between 2018 and 2020.
vue-datepicker/tests/unit/components/VDPicker/VDPickerYears.spec.js
Line 185 in 62211ca
Fixes #85