fix: compare matches to inbound params, parse number 0

[danwalkerdev]

Fix for issue #66

• compare matchable params to inbound.params
• allow the number 0 falsy parameters to be parsed and provided in the props

[mateothegreat]

We're doing some weird stuff in the condition checks.

Getting false positives:

Same condition under main:

[danwalkerdev]

nice catch - it's a little confusing because evaluators can return different types (mainly for the regexp option)

I think checking the type is as expected (from the previously marshalled value) can allow us to let falsy values through if they are of the expected type. I think it's the easiest way of distinguishing whether false from the evaluator means "doesn't match" vs "matches to boolean false", without restructuring what the evaluator returns.

Do you think we need any further checks for the array return types?

Incidentally, I also noticed something like the following didn't parse as expected

test("regexp groups", () => {
    expect(new Query("first=hello:world")
      .test(new Query({
        first: /^(\w+):(\w+)$/,
      })))
      .toEqual({
        condition: 'exact-match',
        ...
      })
})

either with a comma or colon separator. might be a separate thing to look at

[mateothegreat]

nice catch - it's a little confusing because evaluators can return different types (mainly for the regexp option)

I think checking the type is as expected (from the previously marshalled value) can allow us to let falsy values through if they are of the expected type. I think it's the easiest way of distinguishing whether false from the evaluator means "doesn't match" vs "matches to boolean false", without restructuring what the evaluator returns.

Do you think we need any further checks for the array return types?

Incidentally, I also noticed something like the following didn't parse as expected

test("regexp groups", () => {
    expect(new Query("first=hello:world")
      .test(new Query({
        first: /^(\w+):(\w+)$/,
      })))
      .toEqual({
        condition: 'exact-match',
        ...
      })
})

either with a comma or colon separator. might be a separate thing to look at

I think we're safe 🤗

I'll definitely get some more test coverage added on this asap to help us help ourselves!

Thanks!!

• Matthew