Solution 3/3#2207
Open
tavokina wants to merge 4 commits into
Open
Conversation
brespect
suggested changes
May 18, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Seems like your DEMO LINK is not working:
2pasha
suggested changes
May 19, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
take a look on comments below ⬇️
Comment on lines
+103
to
+115
| onBlur={() => { | ||
| if (!isCancelledRef.current) { | ||
| handleSubmit(); | ||
| } | ||
|
|
||
| isCancelledRef.current = false; | ||
| }} | ||
| onKeyUp={e => { | ||
| if (e.key === 'Escape') { | ||
| setIsEditing(false); | ||
| setEditingTitle(todo.title); | ||
| isCancelledRef.current = true; | ||
| } |
Comment on lines
+12
to
+18
| const ERROR_MESSAGES = { | ||
| load: 'Unable to load todos', | ||
| title: 'Title should not be empty', | ||
| add: 'Unable to add a todo', | ||
| delete: 'Unable to delete a todo', | ||
| update: 'Unable to update a todo', | ||
| }; |
There was a problem hiding this comment.
you may move this to /types and use enum instead
Comment on lines
+163
to
+187
| onSubmit={e => { | ||
| e.preventDefault(); | ||
|
|
||
| if (!normalizedTitle) { | ||
| setErrorMessage(ERROR_MESSAGES.title); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| setTempTodo({ | ||
| ...newTodo(normalizedTitle), | ||
| id: 0, | ||
| }); | ||
| todoService | ||
| .addTodo(newTodo(normalizedTitle)) | ||
| .then(addedTodo => { | ||
| setTodos([...todos, addedTodo]); | ||
| setTitle(''); | ||
| setTempTodo(null); | ||
| }) | ||
| .catch(() => { | ||
| setErrorMessage(ERROR_MESSAGES.add); | ||
| setTempTodo(null); | ||
| }); | ||
| }} |
Comment on lines
+229
to
+260
| <a | ||
| href="#/" | ||
| className={classNames('filter__link', { | ||
| selected: status === '', | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setStatus('')} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={classNames('filter__link', { | ||
| selected: status === 'active', | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setStatus('active')} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={classNames('filter__link', { | ||
| selected: status === 'completed', | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setStatus('completed')} | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
you may add all your filter values to enum and map through it
| </span> | ||
|
|
||
| {/* Active link should have the 'selected' class */} | ||
| <nav className="filter" data-cy="Filter"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK