add task solution#2194
Open
AndrewPrszn wants to merge 2 commits into
Open
Conversation
2pasha
suggested changes
May 8, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
take a look on comments below ⬇️
Comment on lines
+37
to
+40
| onClick={e => { | ||
| e.preventDefault(); | ||
| setFilter(f.value); | ||
| }} |
Comment on lines
+53
to
+79
| onBlur={async () => { | ||
| const trimmed = editedTitle.trim(); | ||
|
|
||
| if (trimmed === todo.title) { | ||
| setEditingId(null); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (!trimmed) { | ||
| try { | ||
| await onDelete(todo.id); | ||
| } catch { | ||
| // | ||
| } | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| try { | ||
| await onRename(todo, trimmed); | ||
|
|
||
| setEditingId(null); | ||
| } catch { | ||
| // keep opened | ||
| } | ||
| }} |
Comment on lines
+80
to
+89
| onKeyUp={e => { | ||
| if (e.key === 'Escape') { | ||
| setEditedTitle(todo.title); | ||
| setEditingId(null); | ||
| } | ||
|
|
||
| if (e.key === 'Enter') { | ||
| (e.target as HTMLInputElement).blur(); | ||
| } | ||
| }} |
Comment on lines
+96
to
+99
| onDoubleClick={() => { | ||
| setEditingId(todo.id); | ||
| setEditedTitle(todo.title); | ||
| }} |
Comment on lines
+18
to
+24
| enum ErrorMessage { | ||
| Load = 'Unable to load todos', | ||
| Add = 'Unable to add a todo', | ||
| Delete = 'Unable to delete a todo', | ||
| EmptyTitle = 'Title should not be empty', | ||
| Update = 'Unable to update a todo', | ||
| } |
There was a problem hiding this comment.
it's better to move to separate file inside types` folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK