add task solution #4062
add task solution #4062
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job implementing the core functionality! The Sum component works correctly, and the App component renders all the required instances. I am requesting one small change before approving this submission.
In src/components/Sum.jsx, the output string violates a specific requirement. You need to use a single template literal (string interpolation) for the content inside the <p> tag, as specified in [CHECKLIST ITEM #2].
Instead of mixing strings and variables like Sum of {a} and {b} is {a + b}, please update it to be a single expression: `{`Sum of ${a} and ${b} is ${a + b}`}. This improves readability and meets the task's code style requirements. After you make this fix, it will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum.jsx
Outdated
| @@ -0,0 +1,5 @@ | |||
| export const Sum = ({ a = 0, b = 0 }) => ( | |||
| <p> | |||
| Sum of {a} and {b} is {a + b} | |||
There was a problem hiding this comment.
This violates checklist item #2: 'Use string interpolation inside tag content'. The text should be wrapped in a single template literal like `{`Sum of ${a} and ${b} is ${a + b}`} for better readability and consistency.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! You've successfully addressed the feedback from the previous review by implementing the template literal correctly in the Sum component. The code is clean, efficient, and fully meets all functional requirements and style guidelines. I am happy to approve your solution. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK