task solution #4061
task solution #4061
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on the overall implementation! The components are working correctly, and the logic for default props is spot on.
However, this requires a small change in src/components/Sum/Sum.jsx to meet all the project requirements. The task's checklist specifies that string interpolation should be used for the content inside the tag [CHECKLIST ITEM #2].
Currently, you have:
<p>Sum of {a} and {b} is {a + b}</p>Please update this to use a single template literal like this:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>Once you make this adjustment, your solution will be perfect. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| export const Sum = ({ a = 0, b = 0 }) => { | ||
| return ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: 'Use string interpolation inside tag content'. While your current implementation works, the task requires using a template literal for the entire string. Please change this to {Sum of ${a} and ${b} is ${a + b}}.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed the feedback from the previous review by using string interpolation in the Sum component. Your code is now clean, correct, and perfectly meets all project requirements. The App component is also set up exactly as specified. I'm happy to confirm your solution is ready. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.