solution #4056
solution #4056
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on the core functionality! The Sum component works correctly, and you've set up the App component perfectly to display all the required instances.
I'm asking for one small adjustment to fully meet the project's requirements. In src/components/Sum/Sum.jsx, the solution violates a specific checklist item regarding code style [CHECKLIST ITEM #2]. The text inside the <p> tag should be constructed using a single template literal for better readability.
Here's how you can fix it:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>Once you make this change, your solution will be ready for approval. Keep up the excellent effort!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: 'Use string interpolation inside tag content'. While your current approach works, the task requires you to construct the entire string using a template literal for better readability. For example: {Sum of ${a} and ${b} is ${a + b}}.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! I am approving your submission. You've successfully addressed the feedback from the previous review, and your solution now perfectly meets all the task requirements. The components are well-implemented, the code is clean, and it adheres to all the specified style guidelines. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK