-
Notifications
You must be signed in to change notification settings - Fork 3.7k
finish task #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
finish task #4044
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on the functional implementation! The Sum component works correctly and meets most of the requirements. However, one change is needed to meet the project's coding standards. Your implementation in src/components/Sum/Sum.jsx violates an explicit checklist item [CHECKLIST ITEM #2] which requires using string interpolation inside tag content. Please refactor the <p> tag to use a single template literal, like <p>{Sum of ${a} and ${b} is ${a + b}}</p>. This will make the code cleaner and also removes the need for the result variable. Once you make this adjustment, the solution will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
|
|
||
| return ( | ||
| <p> | ||
| Sum of {a} and {b} is {result} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation doesn't follow the required code style. This violates checklist item #2: 'Use string interpolation inside tag content'.
The text inside the <p> tag should be a single template literal, like {Sum of ${a} and ${b} is ${a + b}}. Using this approach would also make the result variable unnecessary.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on this task! The component's functionality is correct, and you've successfully implemented most of the requirements.
However, this requires a change in src/components/Sum/Sum.jsx to align with the project's style guide. The current implementation violates a specific rule for string formatting [CHECKLIST ITEM #2].
Please update the <p> tag to use a single template literal for the entire string.
-
Current:
Sum of {a} and {b} is {a + b} -
Required:
{Sum of ${a} and ${b} is ${a + b}}
Once you make this adjustment, the task will be complete. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Sum/Sum.jsx
Outdated
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item #2: 'Use string interpolation inside tag content'. While your current code works, the project's style guide requires using a single template literal for the entire string, as shown in the checklist's 'GOOD EXAMPLE'. The correct format should be: {Sum of ${a} and ${b} is ${a + b}}.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Excellent work on this! I am approving your solution as it now perfectly meets all the requirements. You've done a fantastic job addressing the feedback from the previous review, especially by updating the <p> tag in Sum.jsx to use a single template literal as required [CHECKLIST ITEM #2]. The implementation is clean, correct, and demonstrates a great understanding of the concepts. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
DEMO LINK