Develop#999
Open
NemH wants to merge 12 commits into
Open
Conversation
Author
|
https://nemh.github.io/react_phone-catalog/ button near cart and fav icons theme changer |
etojeDenys
suggested changes
May 19, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
great job!
to improve:
- page number should not reset when the page is refreshed
- after selecting products from this section, the page should scroll up
Author
|
Done |
brespect
suggested changes
May 20, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, check next:
- When you select another one in pagination, the page should not scrolls up:
- All this links should refer to proper existing resourses:
-
Add the favicocn and change title in browser tab.
-
The animation in should be the same as out, make it more smooth:
- Pass all tests befiore requesting next review.
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.