Solution#998
Open
ExtymAndriy wants to merge 9 commits into
Open
Conversation
brespect
suggested changes
May 19, 2026
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to share your working DEMO LINK and pass all linter checks before requesting mentor's review
Author
brespect
suggested changes
May 21, 2026
brespect
left a comment
There was a problem hiding this comment.
Good progress, let's start from Detail Page:
- Bread Crumbs icon is broken:
- Why use should see the ID here?
- Buttons are not aligned to left side and favourite icon is brroken:
- This section looks completely different from the mockup, let's check Figma:
- Cards in slider should be full view, not cropped:
- Header should be same color as background:
Author
2pasha
suggested changes
May 21, 2026
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- content container should be the same width for all sections
- it would be great if all images were +- the same sized
- image looks broken
- it will be great if user can delete item from cart by clicking there
- fix images
- footer should always be on the screen bottom
- change favicon and title
- fix layout inside cart
- add total items count and take a look at amount in your header
- implement some functionality for this button
Anton-Kuchmasov
suggested changes
May 22, 2026
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Almost done!
- When User selects any sorting parameters, they should appear in the URL as Search Params
- Most of issues from prev mentor review did not fixed yet (favicon, non-existing icons, footer positioning etc.). Fix all of them, double-check is everything looks fine and then re-request review again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.