Skip to content

Develop#997

Open
ANDRIYTS1234 wants to merge 18 commits into
mate-academy:masterfrom
ANDRIYTS1234:develop
Open

Develop#997
ANDRIYTS1234 wants to merge 18 commits into
mate-academy:masterfrom
ANDRIYTS1234:develop

Conversation

@ANDRIYTS1234
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add you DEMO LINK to PR's description and deploy your app

Image

@ANDRIYTS1234 ANDRIYTS1234 requested a review from 2pasha May 19, 2026 07:08
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previos mentor's comment was not fixed

@ANDRIYTS1234
Copy link
Copy Markdown
Author

Вітаю, не можу розібратись чому в мене не підтягуються фото на демо. Саме демо вже додав

@ANDRIYTS1234 ANDRIYTS1234 requested a review from brespect May 19, 2026 07:31
@ANDRIYTS1234 ANDRIYTS1234 marked this pull request as draft May 19, 2026 07:39
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a problem with the images. if you get stuck, feel free to ask for help in the chat

@ANDRIYTS1234 ANDRIYTS1234 requested a review from etojeDenys May 19, 2026 08:31
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing has changed. make sure you run 'npm run deploy' again

@ANDRIYTS1234 ANDRIYTS1234 requested a review from etojeDenys May 19, 2026 09:56
@ANDRIYTS1234 ANDRIYTS1234 marked this pull request as ready for review May 19, 2026 10:11
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check next:

  1. If I select page item in pagination the page should not scrolls to top.
  2. Also as a notice, pagination "jumping":
Image
  1. Back button should back to previous layer, as example to phones, not to previous phone:
Image
  1. Contacts, Rights should exist, and refer to proper resourses:
Image
  1. Add the favicon and change the title on browser tab.

  2. The favourite icon should be painted over, when selected:

Image

@ANDRIYTS1234 ANDRIYTS1234 requested a review from brespect May 20, 2026 10:08
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants