Skip to content

Test deploy#995

Open
friranger1 wants to merge 3 commits into
mate-academy:masterfrom
friranger1:master
Open

Test deploy#995
friranger1 wants to merge 3 commits into
mate-academy:masterfrom
friranger1:master

Conversation

@friranger1
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to add your DEMO LINK to the PR description. Also, you need to pass all tests and linter checks before requesting the review

@friranger1
Copy link
Copy Markdown
Author

I've started to work on react components and finalized the main page. May I ask you to take a look and let me know if this approach is workable or I have to fix something?

@friranger1 friranger1 requested a review from brespect May 17, 2026 13:27
@friranger1
Copy link
Copy Markdown
Author

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for implemented page, but can't review as there are no details page, phones, accessories, tablet, also no favicon and favourites page looks broken:
Image

Also, let's pass all tests and specially linter checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants