Skip to content

feat: initial commit with project structure and styles#994

Open
AleksanderChaika wants to merge 11 commits into
mate-academy:masterfrom
AleksanderChaika:develop
Open

feat: initial commit with project structure and styles#994
AleksanderChaika wants to merge 11 commits into
mate-academy:masterfrom
AleksanderChaika:develop

Conversation

@AleksanderChaika
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this link https://aleksanderchaika.github.io/react_phone-catalog/

Good job!

A few things to improve:

  1. Images aren't loaded on the website
Image
  1. By clicking on Accessories or Tablet the page isn't found
Image Image
  1. The price here should be changed according to established count
Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. products in this category should be discounted
Image
  1. remove base underlining
Image
  1. after selecting a product from this section, the page should scroll up
Image
  1. these numbers should be the same
Image
  1. add a favicon and a title to the page

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last fixes:

  1. it would be great if you could add some padding to this page
Image
  1. disable page scrolling when the menu is open
Image

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work you did!

To improve:

  1. Images inside the main slider looks slightly cutted. Would you mind to fix it?
Image
  1. It's clear that checkout is not implemented, but can you add a functional to wipe all Cart' data if Checkout button is pressed?
Image
  1. Add some additional info to your Footer. F.e., Contacts link can redirect user to your Linkedin/Telegram/Git profile - who knows, maybe your project will be reviewed by HR from your future job?

  2. Suggest to center this section

Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, just don't forget to fix this

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants