Skip to content

completed tasks#990

Open
qlaudy wants to merge 4 commits into
mate-academy:masterfrom
qlaudy:develop
Open

completed tasks#990
qlaudy wants to merge 4 commits into
mate-academy:masterfrom
qlaudy:develop

Conversation

@qlaudy
Copy link
Copy Markdown

@qlaudy qlaudy commented May 7, 2026

No description provided.

Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please add DEMO LINK to PR description

  2. make sure that you have deployed your app properly, because your main page is empty

Image
  1. fix silder images
Image
  1. i suppose you need to fix your deploy at all
Image
  1. change favicon and title
Image

@qlaudy
Copy link
Copy Markdown
Author

qlaudy commented May 8, 2026

@qlaudy qlaudy requested a review from 2pasha May 8, 2026 11:07
Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. in this section items should be without discount
Image
  1. add some hover effects for these items
Image
  1. i suppose card should be wider to avoid this
Image
  1. it's better to add some external links which will be opened in new tabs
Image

@qlaudy
Copy link
Copy Markdown
Author

qlaudy commented May 11, 2026

@qlaudy qlaudy requested a review from 2pasha May 11, 2026 09:11
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

To improve:

  1. This sliders should contain only 4 cards on PC view. Would you mind to reduce max-width of the whole layout on big screens, as it is on Figma mockup?
Image
  1. Seems like minor diff between your implementation and Figma, but it should be fixed:
Image
  1. The same as #1 in your Main Slider - but, perhaps, if (or when) you'll reduce max-width to your Layout, this slider will looks better
Image

@qlaudy
Copy link
Copy Markdown
Author

qlaudy commented May 11, 2026

@qlaudy qlaudy requested a review from Anton-Kuchmasov May 11, 2026 17:55
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants