solution react_phone-catalog#989
Open
opalahecha wants to merge 3 commits into
Open
Conversation
brespect
suggested changes
May 6, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, almost done check next:
-
When I search "Iphone Gold" I want to get all golden phones that are presented, including all models. For now it shows me nothing.
-
Back button should back me to the previous layer, not to the previous Iphone. In this case it should be Phones Catalog Page:
-
All links in Footer should lead to proper existinmg resources.
-
There should be no scroll on empty page, check the shopping cart also:
- Search Bar should not be cropped on small mobile screeen:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO