Develop#988
Open
Mykolyan wants to merge 30 commits into
Open
Conversation
…tes and Header components
…dd Loader component and ProductsList for better loading and display handling
… accessibility and styling; update HomePage to use brand new and hot prices APIs
…dd custom hooks and styles for enhanced layout and interactivity; update Pagination and ProductCard styling
…ryPage route guard for invalid categories; update HomePage to compute brand new and hot prices locally; clean up API and hooks exports
…ayouts; unify card grid styling; enhance banner slider props and swipe logic; clean up SCSS for HomePage, FavouritesPage, and Footer
… add quantity controls and checkout handling; style CartPage and CartItem; integrate cart into Header
…pdate styles for CartItem and CartPage; refactor HomePage to utilize ProductsSlider for displaying brand new and hot prices
- Add base path to vite.config.ts for correct asset resolution under /react_phone_catalog/ subpath - Update BASE_URL in api/index.ts to use import.meta.env.BASE_URL for environment-aware fetching - Add getImageUrl() utility to normalize public image paths using the Vite base URL
brespect
suggested changes
May 6, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to all CI checks (linter and tests) before requesting review
2pasha
suggested changes
May 7, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- items here should be without discounts
- user should have ability to open product detail page by clicking here
Author
|
@2pasha thank you for your review |
…dded showDiscount prop, for different cases, whatever show discount or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mykolyan.github.io/react_phone-catalog/