Develop#984
Open
Yar14k wants to merge 139 commits into
Open
Conversation
Author
Anton-Kuchmasov
suggested changes
May 3, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Good job, to improve:
-
Make all sliders infinite (see
loopattribute for Swiper) -
When User clicks on any product card in this section, there should be smooth scroll to the top - otherwise they can't clarify, was the navigation successful or not
Author
brespect
suggested changes
May 4, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, check next:
- Add some margins to this section:
- There should be no vertical scroll on empty page, check everywhere:
-
Add the favicon.
-
Pass all tests and linter checks before requesting the next review
Author
etojeDenys
suggested changes
May 4, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
almost done
- it would be better to open these links in a new tab
- there should not be any scrolling when the favourites section is empty
- also here. the footer should be visible without scrolling if there are no products or a small number of products in the cart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.