Mit#983
Open
mitnues wants to merge 14 commits into
Open
Conversation
IanLuan
suggested changes
Apr 30, 2026
IanLuan
left a comment
There was a problem hiding this comment.
Your code looks good, but the DEMO LINK is missing. Please run the deploy.
Author
pedro-ruas
suggested changes
Apr 30, 2026
pedro-ruas
left a comment
There was a problem hiding this comment.
The design of the page doesn't match the one proposed by the task.
- Fonts are different
- Items positioning is different
- Colors are different
- Multiple functionalities do not work
- Products do not load in any page
- Icons don't change with interactions
- Images do not load
- There are also elements that should not be there, like the reload button in catalog pages
Author
|
it was working good in npm start, mabe e had problem in demolink again. |
Author
IanLuan
suggested changes
May 7, 2026
IanLuan
left a comment
There was a problem hiding this comment.
Great progress, you’re almost there! However, there are a few changes needed to improve your project:
- The design could be closer to the mockup. Review the font family, the Shop by Category section, the cart and favorites pages, the product page, and the home page carousel.
- The product does not change when selecting another color or capacity.
- The pagination has a bug: if I select 4 items per page, it displays 4 items, but when I go to the next page, it shows many items.
- The search is not working properly. As soon as I start typing, it freezes the page while searching. If you want to keep it, add debounce to the search input.
IanLuan
suggested changes
May 11, 2026
IanLuan
left a comment
There was a problem hiding this comment.
Great progress! You solved almost all the problems. However, when I change the capacity of a product inside the product details page, the product does not change. It should work the same way as the color selection.
IanLuan
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.