Skip to content

Mit#983

Open
mitnues wants to merge 14 commits into
mate-academy:masterfrom
mitnues:mit
Open

Mit#983
mitnues wants to merge 14 commits into
mate-academy:masterfrom
mitnues:mit

Conversation

@mitnues
Copy link
Copy Markdown

@mitnues mitnues commented Apr 29, 2026

No description provided.

Copy link
Copy Markdown

@IanLuan IanLuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code looks good, but the DEMO LINK is missing. Please run the deploy.

@mitnues
Copy link
Copy Markdown
Author

mitnues commented Apr 30, 2026

@mitnues mitnues requested a review from IanLuan April 30, 2026 19:05
Copy link
Copy Markdown

@pedro-ruas pedro-ruas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of the page doesn't match the one proposed by the task.

  • Fonts are different
  • Items positioning is different
  • Colors are different
  • Multiple functionalities do not work
    • Products do not load in any page
    • Icons don't change with interactions
    • Images do not load
  • There are also elements that should not be there, like the reload button in catalog pages

@mitnues
Copy link
Copy Markdown
Author

mitnues commented May 1, 2026

it was working good in npm start, mabe e had problem in demolink again.

@mitnues
Copy link
Copy Markdown
Author

mitnues commented May 6, 2026

@mitnues mitnues requested a review from pedro-ruas May 6, 2026 18:45
Copy link
Copy Markdown

@IanLuan IanLuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress, you’re almost there! However, there are a few changes needed to improve your project:

  • The design could be closer to the mockup. Review the font family, the Shop by Category section, the cart and favorites pages, the product page, and the home page carousel.
  • The product does not change when selecting another color or capacity.
  • The pagination has a bug: if I select 4 items per page, it displays 4 items, but when I go to the next page, it shows many items.
  • The search is not working properly. As soon as I start typing, it freezes the page while searching. If you want to keep it, add debounce to the search input.

@mitnues mitnues requested a review from IanLuan May 8, 2026 20:27
Copy link
Copy Markdown

@IanLuan IanLuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! You solved almost all the problems. However, when I change the capacity of a product inside the product details page, the product does not change. It should work the same way as the color selection.

@mitnues mitnues requested a review from IanLuan May 11, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants