Skip to content

Solution#982

Open
wolfymmm wants to merge 37 commits into
mate-academy:masterfrom
wolfymmm:develop
Open

Solution#982
wolfymmm wants to merge 37 commits into
mate-academy:masterfrom
wolfymmm:develop

Conversation

@wolfymmm
Copy link
Copy Markdown

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to pass all CI checks, including linter, before requesting the review

@wolfymmm
Copy link
Copy Markdown
Author

Good progress, but you need to pass all CI checks, including linter, before requesting the review

Initially I had a few critical EsLint errors that I resolved, but when I ran the linter after the final error, the terminal suddenly showed 399 errors😭
image
image

@wolfymmm wolfymmm requested a review from brespect April 29, 2026 13:40
@wolfymmm
Copy link
Copy Markdown
Author

image In terminal now I don't have any problems when I try to commit or deploy. I don't know why linter checks on GitHub failed. But when I execute "npm run lint" I have 399+ problems

@wolfymmm
Copy link
Copy Markdown
Author

After this deployment my project has broken both locally and on GitHub pages. My grid now is jumping and filters arrow isn't displaying only on GitHub pages. But before everything worked locally and after deployment. I did nothing with grid or this icon

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job you did!

To improve:

  1. Those cards are looking different by UI implementation What is 6 GB row mean in the bottom of card #1?
Image
  1. Looks like sorting works slightly wrong. Are Apple Watch 3 Series the newest generation ever?
Image

Also, pay attention: Most Expensive 6 Cheapest sorting params looks broken too:

Image
  1. Fill Navlinks of your Footer section. Github should be an external link to your Github repo, Contacts - maybe, your CV / Linkedin Profile, Rights can contain a placeholder or redirect to 404 as it is now

Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🔥

user should have ability to open Product Details page by clicking here

Image

@wolfymmm wolfymmm requested a review from 2pasha April 29, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants