Develop#981
Open
berezandiana wants to merge 5 commits into
Open
Conversation
brespect
suggested changes
Apr 28, 2026
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to pass all tests and linter checks before requesting mentor's review
brespect
suggested changes
Apr 29, 2026
brespect
left a comment
There was a problem hiding this comment.
Almost done, cehck this:
- When you select page in pagination section the page should not scrolls to top:
- You have localization for your app, its really nice thing, but it is strange for me that this section is on English while I select the UA:
- When I select something in "You may also like section" I expect the page will scroll to the top:
- "Back" button under the "Bread Crumbs" should back me to the navigation, as example to toablet, not to previous model I selected:
-
All links in Footer should refer to proper existing resourses.
-
Remove vertical scroll on empty page:
- Make the logo default black color on Mobile, as for now, it is hard to see it in side menu:
Anton-Kuchmasov
suggested changes
Apr 29, 2026
etojeDenys
suggested changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







https://berezandiana.github.io/react_phone-catalog/