Skip to content

Develop#981

Open
berezandiana wants to merge 5 commits into
mate-academy:masterfrom
berezandiana:develop
Open

Develop#981
berezandiana wants to merge 5 commits into
mate-academy:masterfrom
berezandiana:develop

Conversation

@berezandiana
Copy link
Copy Markdown

@berezandiana berezandiana marked this pull request as draft April 28, 2026 00:15
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to pass all tests and linter checks before requesting mentor's review

@berezandiana berezandiana requested a review from brespect April 28, 2026 16:50
@berezandiana berezandiana marked this pull request as ready for review April 28, 2026 17:45
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, cehck this:

  1. When you select page in pagination section the page should not scrolls to top:
Image
  1. You have localization for your app, its really nice thing, but it is strange for me that this section is on English while I select the UA:
Image
  1. When I select something in "You may also like section" I expect the page will scroll to the top:
Image
  1. "Back" button under the "Bread Crumbs" should back me to the navigation, as example to toablet, not to previous model I selected:
Image
  1. All links in Footer should refer to proper existing resourses.

  2. Remove vertical scroll on empty page:

Image
  1. Make the logo default black color on Mobile, as for now, it is hard to see it in side menu:
Image

@berezandiana berezandiana requested a review from brespect April 29, 2026 09:43
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

To improve:

  1. Remove this bars (both):
Image
  1. It's better to reset [Css Autofill](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Selectors/:autofill) styles in your Search bar:
Image
  1. On some accessoires' pages, first color of the list is not clickable. Is it space gray? It should work too
Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last fixes:

  1. products in this section should now be discounted
Image
  1. this card should link to the product page
Image
  1. slightly decrease scale of the hovered image to avoid merging and overlapping
Image
  1. it would be useful to be able to remove the product after pressing the button again
Image

@berezandiana berezandiana requested a review from etojeDenys April 30, 2026 10:49
Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants