Skip to content

Develop#980

Open
AnnaAAA3432 wants to merge 3 commits into
mate-academy:masterfrom
AnnaAAA3432:develop
Open

Develop#980
AnnaAAA3432 wants to merge 3 commits into
mate-academy:masterfrom
AnnaAAA3432:develop

Conversation

@AnnaAAA3432
Copy link
Copy Markdown

@AnnaAAA3432 AnnaAAA3432 commented Apr 27, 2026

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to share your DEMO LINK to the Git Hub Pages, not to the repository

@AnnaAAA3432 AnnaAAA3432 requested a review from brespect April 28, 2026 13:19
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, but you should fix the problems with the icons

Image

also add a title and favicon

Image

@AnnaAAA3432 AnnaAAA3432 requested a review from etojeDenys April 29, 2026 14:24
Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🔥

Comment on lines +52 to +56
onClick={e => {
e.preventDefault();
e.stopPropagation();
deletCard(item.id);
}}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to separate fn

Comment on lines +74 to +78
onClick={e => {
e.preventDefault();
e.stopPropagation();
increase(item.id);
}}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to separate fn

Comment on lines +87 to +92
onClick={e => {
e.preventDefault();
e.stopPropagation();
decrease(item.id);
}}
>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to separate fn

Comment on lines +54 to +58
onClick={() =>
window.scrollTo({
top: 0,
behavior: 'smooth',
})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to separate fn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants