Skip to content

Develop#977

Open
Vladislav-Korsun wants to merge 13 commits into
mate-academy:masterfrom
Vladislav-Korsun:develop
Open

Develop#977
Vladislav-Korsun wants to merge 13 commits into
mate-academy:masterfrom
Vladislav-Korsun:develop

Conversation

@Vladislav-Korsun
Copy link
Copy Markdown

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, cehck next:

  1. Pass all test before requesting next review.

  2. Cards in the scroller should not be cropped.

Image
  1. When I select something in "You may also like" section, the page should smoothly scrolls to the top.

  2. Add the favicon and change title in the browser tab.

Vladislav-Korsun added 2 commits April 26, 2026 23:03
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Still not fixed:
Image

2., Pagination should be at the bottom of page:
Image

  1. Align the bread crumbs:
Image
  1. Page should not blicking when I select colors/memory size.

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but:

  1. How I can close this on mobile?
Image
  1. Better not to crop the scroll bar:
Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. these links should work
Image
  1. make sure these numbers are the same
Image
  1. header should be bigger on the desktop version
Image

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants