Skip to content

add task solution#976

Open
IvanovvvIhor wants to merge 8 commits into
mate-academy:masterfrom
IvanovvvIhor:develop
Open

add task solution#976
IvanovvvIhor wants to merge 8 commits into
mate-academy:masterfrom
IvanovvvIhor:develop

Conversation

@IvanovvvIhor
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. change title and favicon
Image
  1. items in this section should be without any discount
Image
  1. make sure that you are using right fonts

  2. make sure that you have done design from Figma here

Image
  1. add real links here
Image

@IvanovvvIhor IvanovvvIhor requested a review from 2pasha April 23, 2026 16:04
Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. When I choose 4 cards per page the arrow buttons are hidden
Image
  1. It's better to disable scrolling when menu is open
Image
  1. I would recommend to export icons/logos in .svg format from Figma for better quality
Image Image Image
  1. Breadcrumbs go outside the phone size
Image Image
  1. Checkout block is broken on phone
Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, to improve:

  1. loader looks broken
Image Image
  1. products in this section should not be discounted
Image
  1. it would be better to open this link in a new tab
Image
  1. add some space here
Image

@IvanovvvIhor IvanovvvIhor requested a review from etojeDenys April 24, 2026 18:46
Copy link
Copy Markdown

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 🔥

please fix last moments:

  1. footer always should be in the page bottom
Image
  1. items here should be without discount
Image

@IvanovvvIhor IvanovvvIhor requested a review from 2pasha April 25, 2026 09:50
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job you did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants