Skip to content

trying to pass tests#975

Open
7uckingbad wants to merge 7 commits into
mate-academy:masterfrom
7uckingbad:solution
Open

trying to pass tests#975
7uckingbad wants to merge 7 commits into
mate-academy:masterfrom
7uckingbad:solution

Conversation

@7uckingbad
Copy link
Copy Markdown

@7uckingbad 7uckingbad commented Apr 20, 2026

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but you need to pass all CI checks and put your DEMO LINK into PR`s description

@7uckingbad 7uckingbad requested a review from brespect April 20, 2026 13:36
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo link does not work. please fix it and re-request the review

@7uckingbad
Copy link
Copy Markdown
Author

demo link does not work. please fix it and re-request the review

https://react-phone-catalog-git-solution-7uckingbads-projects.vercel.app/

у меня открывает , переделать нужно?

@7uckingbad 7uckingbad requested a review from etojeDenys April 21, 2026 08:04
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. add hover effects to the cards
Image
  1. slightly decrease the scale of the hovered image because it now merges with the other items
Image
  1. there is too much space
Image
  1. make sure the cards are the same
Image
  1. buttons do not work
Image
  1. it should link to the product cart
Image
  1. after reloading the non-homepage, we see the error
Image
  1. it would be useful to be able to remove the product by pressing the button again
Image

@7uckingbad 7uckingbad requested a review from etojeDenys April 22, 2026 12:13
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

  1. Check out width of these cards. It should be slightly shorter (on width):
Image

Make sense to add only 4 cards in a grid row, other space should be as paddings (grid is centered on the page btw):

Image
  1. Add a link to your Github repo in the Github navlink inside a Footer

@7uckingbad
Copy link
Copy Markdown
Author

Make sense to add only 4 cards in a grid row, other space should be as paddings (grid is centered on the page btw):
Спасибо!

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, now add a title and a favicon

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants