Develop#973
Open
redfield-mp wants to merge 109 commits into
Open
Conversation
… typography, and spacing
…out` components to `layout/` directory
…out` components to `modules/shared/` directory
…rumbs`, `ProductCard`, and `ProductsList`
…ts with basic structure and styling
…ith `NavLink` for "Favorites" and "Cart" links
…ved design and functionality
…isually hidden title for accessibility
brespect
suggested changes
Apr 17, 2026
brespect
left a comment
There was a problem hiding this comment.
Good progress, check this:
- Contact and Rights pages should not be empty, should link to proper existing resourses or well implemented own pages:
- Remove broken items:
- All card images should be same size:
- Products in this section should not have discount:
- When you select something in "You may also like" section, page should smoothly scroll to the top.
Author
|
Denys-Kravchuk9988
suggested changes
Apr 17, 2026
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
A few things to improve:
- By change color the phones images should also be changed to appropriate color (same for memory size)
- I would recommend to add logic when user clicks on Added to cart button the phone is deleted from cart.
- By change the count it's better to recalculate sum
- Phones in this section shouldn't be with discount according to design
- It's better to align footer's content to left side according to design
Author
|
vadiimvooo
suggested changes
Apr 18, 2026
vadiimvooo
left a comment
There was a problem hiding this comment.
Almost done. Just fix add to cart button to be able to remove item from cart as Denys suggested in previous comment. The behaviour should be the same as with favourite button. Please feel free to ask for help in fe_chat.
Author
|
Done. But I have the following suggestion in the README.md file:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo link