Skip to content

Develop#973

Open
redfield-mp wants to merge 109 commits into
mate-academy:masterfrom
redfield-mp:develop
Open

Develop#973
redfield-mp wants to merge 109 commits into
mate-academy:masterfrom
redfield-mp:develop

Conversation

@redfield-mp
Copy link
Copy Markdown

…out` components to `modules/shared/` directory
…rumbs`, `ProductCard`, and `ProductsList`
…ith `NavLink` for "Favorites" and "Cart" links
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check this:

  1. Contact and Rights pages should not be empty, should link to proper existing resourses or well implemented own pages:
Image
  1. Remove broken items:
Image
  1. All card images should be same size:
Image
  1. Products in this section should not have discount:
Image
  1. When you select something in "You may also like" section, page should smoothly scroll to the top.

@redfield-mp
Copy link
Copy Markdown
Author

  1. Added content.
  2. Fixed.
  3. Different images have different sizes. Should I crop images?
  4. If the product should not have a discount, then what type of cost should I show: "priceRegular" or "priceDiscount"? If I remove the discount from the "Brand new models" section, then should I remove it from the "ProductDetailsPage"?
  5. Added.

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. By change color the phones images should also be changed to appropriate color (same for memory size)
Image
  1. I would recommend to add logic when user clicks on Added to cart button the phone is deleted from cart.
Image
  1. By change the count it's better to recalculate sum
Image
  1. Phones in this section shouldn't be with discount according to design
Image Image
  1. It's better to align footer's content to left side according to design
Image Image

@redfield-mp
Copy link
Copy Markdown
Author

  1. Done.
  2. I need some clarification on this task, as it doesn't seem to be mentioned in README.md.
  3. Done.
  4. Done.
  5. Done.

Copy link
Copy Markdown

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done. Just fix add to cart button to be able to remove item from cart as Denys suggested in previous comment. The behaviour should be the same as with favourite button. Please feel free to ask for help in fe_chat.

@redfield-mp
Copy link
Copy Markdown
Author

Done. But I have the following suggestion in the README.md file:

  1. If the product is already in the Cart the button should say Added to cart and do nothing.

@redfield-mp redfield-mp requested a review from vadiimvooo April 18, 2026 18:58
Copy link
Copy Markdown

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants