Skip to content

Develop#1014

Open
ValentynaITCh wants to merge 19 commits into
mate-academy:masterfrom
ValentynaITCh:develop
Open

Develop#1014
ValentynaITCh wants to merge 19 commits into
mate-academy:masterfrom
ValentynaITCh:develop

Conversation

@ValentynaITCh

Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. It's better to improve pagination. By clicking on prev and next arrows the page should be decreased or increased. Active pagination's tile should always be visible.
Image
  1. Page's content goes outside on phone's screen size
Image
  1. It's better to disable scrolling when menu is open
Image
  1. By clicking on arrows the card is partly hidden
Image
  1. I would recommend to replace symbols on icons (export in .svg from Figma)
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants