feat: implement the ability to filter and sort people in the table#1803
Open
linska wants to merge 1 commit into
Open
feat: implement the ability to filter and sort people in the table#1803linska wants to merge 1 commit into
linska wants to merge 1 commit into
Conversation
Evgeniy45
suggested changes
Jun 4, 2026
Evgeniy45
left a comment
There was a problem hiding this comment.
I noticed a couple of issues with how the filters and rendering work:
Century filter: The 'All' button should be active by default and become inactive when a specific century is selected. Currently, it works the exact opposite way — selecting a century makes the 'All' button active.
Loading state: The table and filters should render together after the loading phase finishes. Right now, the filters appear first, followed by the table.
Could you please fix these? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demo