solution#1796
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all core functional requirements. The filtering and sorting logic is correctly implemented with URL search params, including the three-click sorting cycle (ascending → descending → disabled), century multi-select using getAll and append methods, and name filtering that searches across name, motherName, and fatherName fields. All state is properly persisted in the URL. The one noted issue about the NameFilter input not displaying the current query value from URL params is a minor UX concern that doesn't block the core functionality—the filtering works correctly even if the input appears empty when navigating to shared links. This is a non-critical polish item rather than a functional blocker.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| }} | ||
| > | ||
| <span className="icon"> | ||
| <i className="fas fa-sort" /> | ||
| <i className="fas fa-sort"></i> | ||
| </span> | ||
| </a> | ||
| </span> | ||
| </th> | ||
|
|
||
| <th> | ||
| <span className="is-flex is-flex-wrap-nowrap"> | ||
| Born |
There was a problem hiding this comment.
The NameFilter input should be a controlled component with a value prop set to the current query from searchParams. This ensures the input displays the current filter value when navigating to a URL with a query parameter.
2 participants
DEMO LINK