Skip to content

done#1774

Open
bcheban wants to merge 1 commit into
mate-academy:masterfrom
bcheban:develop
Open

done#1774
bcheban wants to merge 1 commit into
mate-academy:masterfrom
bcheban:develop

Conversation

@bcheban
Copy link
Copy Markdown

@bcheban bcheban commented May 5, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. All core requirements have been successfully implemented: URL search params correctly handle both filtering (query, centuries) and sorting (sort, order), the three-click sorting cycle (ascending → descending → disabled) works as expected, and the sidebar appears only when people are loaded. The NameFilter properly updates/removes the query param, and CenturyFilter correctly uses getAll and append methods for multiple selections. Name filtering matches against name, motherName, and fatherName case-insensitively, and search params are preserved when navigating between /people and /people/:slug routes. Great work on meeting all the checklist requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants