Skip to content

add solution #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ratseburzhynskyi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add solution #1180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a620a76
add solution
ratseburzhynskyi May 14, 2026
813a2c0
fixed
ratseburzhynskyi May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 68 additions & 38 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,73 +1,103 @@
import React from 'react';
import React, { useMemo, useState } from 'react';
import debounce from 'lodash.debounce';
import './App.scss';
import { peopleFromServer } from './data/people';

export const App: React.FC = () => {
const { name, born, died } = peopleFromServer[0];
type Person = (typeof peopleFromServer)[number];

type Props = {
onSelected?: (person: Person) => void;
delay?: number;
};

export const App: React.FC<Props> = ({ onSelected, delay = 300 }) => {
const [query, setQuery] = useState('');
const [debouncedQuery, setDebouncedQuery] = useState('');
const [isOpen, setIsOpen] = useState(false);
const [selectedPerson, setSelectedPerson] = useState<Person | null>(null);

const normalizedQuery = debouncedQuery.trim().toLowerCase();

let filteredPeople = peopleFromServer;

if (normalizedQuery) {
filteredPeople = peopleFromServer.filter(person => {
return person.name.toLowerCase().includes(normalizedQuery);
});
Comment on lines +20 to +26
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filteredPeople computation runs on every render without memoization. Consider using useMemo since it depends on debouncedQuery and the filtering operation could be expensive.

}

const applyDebounce = useMemo(() => {
return debounce((value: string) => {
setDebouncedQuery(value);
}, delay);
Comment on lines +28 to +32
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useMemo for applyDebounce has an empty dependency array but uses delay in its factory function. If delay prop changes, this won't recreate the debounce. Either include delay in the dependency array or use a different pattern.

}, []);

Check warning on line 33 in src/App.tsx

View workflow job for this annotation

GitHub Actions / run_linter (20.x) 

React Hook useMemo has a missing dependency: 'delay'. Either include it or remove the dependency array

return (
<div className="container">
<main className="section is-flex is-flex-direction-column">
<h1 className="title" data-cy="title">
{`${name} (${born} - ${died})`}
{selectedPerson
? `${selectedPerson.name} (${selectedPerson.born} - ${selectedPerson.died})`
: 'No selected person'}
</h1>

<div className="dropdown is-active">
<div className={`dropdown ${isOpen ? 'is-active' : ''}`}>
<div className="dropdown-trigger">
<input
type="text"
placeholder="Enter a part of the name"
className="input"
data-cy="search-input"
value={query}
onChange={event => {
setQuery(event.target.value);
setSelectedPerson(null);

applyDebounce(event.target.value);
setIsOpen(true);
}}
onFocus={() => setIsOpen(true)}
/>
</div>

<div className="dropdown-menu" role="menu" data-cy="suggestions-list">
<div className="dropdown-content">
<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Haverbeke</p>
</div>
{filteredPeople.map(person => (
<div
key={person.slug}
className="dropdown-item"
data-cy="suggestion-item"
onClick={() => {
setSelectedPerson(person);
setQuery(person.name);
setDebouncedQuery(person.name);
setIsOpen(false);

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Bernard Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Antone Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Petronella de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Hercke</p>
</div>
onSelected?.(person);
}}
>
<p>{person.name}</p>
</div>
))}
</div>
</div>
</div>

<div
className="
{query !== '' && filteredPeople.length === 0 && (
<div
className="
notification
is-danger
is-light
mt-3
is-align-self-flex-start
"
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
)}
</main>
</div>
);
Expand Down
Loading