develop #1175
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import React, { useEffect, useMemo, useState } from 'react'; | ||
| import { Person } from '../types/Person'; | ||
|
|
||
| type Props = { | ||
| people: Person[]; | ||
| delay?: number; | ||
| onSelected: (person: Person | null) => void; | ||
| }; | ||
|
|
||
| export const Autocomplete: React.FC<Props> = ({ | ||
| people, | ||
| delay = 300, | ||
| onSelected, | ||
| }) => { | ||
| const [query, setQuery] = useState(''); | ||
| const [appliedQuery, setAppliedQuery] = useState(''); | ||
| const [isOpen, setIsOpen] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const timerId = window.setTimeout(() => { | ||
| setAppliedQuery(query); | ||
| }, delay); | ||
|
|
||
| return () => { | ||
| window.clearTimeout(timerId); | ||
| }; | ||
| }, [query, delay]); | ||
|
|
||
| const visiblePeople = useMemo(() => { | ||
| return people.filter(person => | ||
| person.name.toLowerCase().includes(appliedQuery.toLowerCase()), | ||
| ); | ||
| }, [people, appliedQuery]); | ||
|
|
||
| const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| setQuery(event.target.value); | ||
| setIsOpen(true); | ||
| onSelected(null); | ||
|
There was a problem hiding this comment. The selection clearing is too aggressive. Currently |
||
| }; | ||
|
|
||
| const handleSelect = (person: Person) => { | ||
| setQuery(person.name); | ||
| setAppliedQuery(person.name); | ||
| setIsOpen(false); | ||
| onSelected(person); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className={`dropdown ${isOpen ? 'is-active' : ''}`}> | ||
| <div className="dropdown-trigger"> | ||
| <input | ||
| type="text" | ||
| placeholder="Enter a part of the name" | ||
| className="input" | ||
| data-cy="search-input" | ||
| value={query} | ||
| onChange={handleChange} | ||
| onFocus={() => setIsOpen(true)} | ||
| onBlur={() => setTimeout(() => setIsOpen(false), 200)} | ||
| /> | ||
| </div> | ||
|
|
||
| {isOpen && ( | ||
| <div className="dropdown-menu" role="menu" data-cy="suggestions-list"> | ||
| <div className="dropdown-content"> | ||
| {visiblePeople.length > 0 ? ( | ||
| visiblePeople.map(person => ( | ||
| <div | ||
| key={person.slug} | ||
| className="dropdown-item" | ||
| data-cy="suggestion-item" | ||
| onClick={() => handleSelect(person)} | ||
| > | ||
| <p className="has-text-link">{person.name}</p> | ||
| </div> | ||
| )) | ||
| ) : ( | ||
| <div | ||
| className=" | ||
| notification | ||
| is-danger | ||
| is-light | ||
| mt-3 | ||
| is-align-self-flex-start | ||
| " | ||
| role="alert" | ||
| data-cy="no-suggestions-message" | ||
| > | ||
| <p className="has-text-danger">No matching suggestions</p> | ||
| </div> | ||
| )} | ||
| </div> | ||
| </div> | ||
| )} | ||
| </div> | ||
| ); | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item #1: filter is called when user enters spaces only. The filter runs with whitespace (
appliedQuery.toLowerCase().includes(' ')) instead of skipping the filter when input is only whitespace. Consider checking ifappliedQuery.trim()is empty and returning all people in that case.