Edit task.sql

[Dima-shima]

No description provided.

[mateacademy-ai-mentor]

Review Summary

I am requesting changes because the current task.sql does not yet implement all required indexes based on the described usage patterns, which is a core requirement of the task. You correctly created indexes on Products.Name, Products.WarehouseAmount, and Customers.Email, with names matching the column names, so that part of the requirement is satisfied. However, there are no indexes on Orders.CustomerID or Orders.Date, even though the task description states that queries will frequently filter orders by customer and date; this means a key requirement is missing and impacts performance-focused functionality. Similarly, OrderItems has no indexes on OrderID or ProductID, despite the scenario explicitly implying heavy access by OrderID (items per order) and likely by ProductID (orders containing a product), so those indexes also need to be added to fully meet the task expectations.

To fix this, extend task.sql with CREATE INDEX statements for CustomerID and Date on the Orders table, and for OrderID and ProductID on the OrderItems table, naming each index exactly after its column (for example, CREATE INDEX CustomerID ON Orders (CustomerID);). The environment error about "No database selected" is a workflow/configuration issue and not your fault, so you don’t need to change your solution for that unless your course explicitly asks you to modify task.sql to include a USE <database_name>; statement. Once these missing indexes are added, your solution will align well with both the usage analysis and the checklist requirements. You’re close—your existing indexes are correct; you just need to cover the remaining tables and columns described in the scenario.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

According to the usage scenarios, Orders will frequently be queried by customer and by date. You should also create indexes on Orders(CustomerID) and Orders(Date), with index names matching the column names, to fully satisfy the requirement to index all needed tables/columns.

[mateacademy-ai-mentor]

OrderItems is not indexed here at all, but it will be used heavily via OrderID (to fetch items belonging to an order) and likely ProductID. Consider adding indexes CREATE INDEX OrderID ON OrderItems (OrderID); and CREATE INDEX ProductID ON OrderItems (ProductID); so that all necessary tables from the description are covered.

[mateacademy-ai-mentor]

Review Summary

I am approving your solution because task.sql correctly defines all required indexes on the ShopDB tables, with index names matching their column names as specified, and the file contains only CREATE INDEX statements. You covered the key usage-based indexes, including Orders.CustomerID, Orders.Date, OrderItems.OrderID, OrderItems.ProductID, and the frequently searched Products.Name and Customers.Email, which satisfies the functional requirements [CHECKLIST ITEM #1, #3, #8, #13]. The CI error about ERROR 1046 (3D000): No database selected is an environment/configuration issue: the automated runner expected a USE statement in task.sql, while your task instructions explicitly say not to include database-selection logic, so this should not be counted against you. Functionally, assuming create-database.sql was run and the correct database selected in your own environment, your script will execute without errors and create the intended indexes [CHECKLIST ITEM #2, #7, #9]. As a minor note for your own practice, in real projects where the environment isn’t pre-selecting a database, you’d typically add USE ShopDB; at the top of such scripts, but for this assignment you correctly followed the given constraints. Nicely done following the requirements precisely and covering all relevant columns for indexing.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Review Summary

I am approving your solution as an educational override so you can continue progressing while you learn, but there are a couple of important adjustments to make. Your choice of indexes is strong: you covered email-based logins, product name searches, and efficient lookups for orders and order items, and your index names correctly match their corresponding columns. However, in task.sql you should remove the USE ShopDB; statement (around the first line), because the environment already selects the database via create-database.sql, and this file is supposed to contain only CREATE INDEX statements. The automated tests also report that the number of indexes does not match what is expected, so you should double-check the task instructions and test.sql to ensure you are creating exactly the required indexes—no extra ones and none missing. Once you remove USE ShopDB; and align the exact set of indexes with the requirements, your solution will fully match both the assignment and the tests. Overall, you’re very close, and these refinements will help you solidify both your SQL style and your understanding of how the testing environment is structured.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

The task description only asks you to save the code for creating indexes in task.sql; database selection is managed separately via create-database.sql and your connection. To align strictly with the requirements, remove the USE ShopDB; line and keep only the CREATE INDEX statements here.

[Losiev]

Well done!👏