'Solution'#182
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The index naming violates the explicit requirement that indexes should be named the same as the columns for which they are created. Indexes named 'index_product' and 'index_customer' must be renamed to 'Name' and 'Email' respectively.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -1,2 +1,4 @@ | |||
| # Write your SQL code for the database creation here. Good luck! | |||
| USE ShopDB; | |||
| CREATE INDEX index_product ON Products(Name); | |||
There was a problem hiding this comment.
Index name must match the column name. Change index_product to Name.
| # Write your SQL code for the database creation here. Good luck! | ||
| USE ShopDB; | ||
| CREATE INDEX index_product ON Products(Name); | ||
| CREATE INDEX index_customer ON Customers(Email); |
There was a problem hiding this comment.
Index name must match the column name. Change index_customer to Email.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution correctly implements all requirements for creating database indexes based on the usage scenarios. The Name index on Products(Name) supports product searches, while the Email index on Customers(Email) optimizes customer login operations. All previous naming issues have been resolved—indexes are now properly named to match their respective columns. The task.sql file includes both CREATE INDEX statements along with the USE ShopDB statement for database connection. Great work on implementing the indexes as specified!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.